Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the Reference -> Command Line section #609

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

gabrielBusta
Copy link
Member

Found myself browsing the codebase after reading reference/cli.html. Thought it'd be good to add more information about what the taskgraph sub-commands represent on this page.

@gabrielBusta gabrielBusta added documentation Improvements or additions to documentation python Pull requests that update Python code labels Dec 5, 2024
@gabrielBusta gabrielBusta requested review from a team and ahal December 5, 2024 17:31
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.34%. Comparing base (59e0e04) to head (deeb281).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files         125      125           
  Lines       10003    10003           
  Branches     1933     1933           
=======================================
  Hits         7337     7337           
  Misses       2342     2342           
  Partials      324      324           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change made me realize that there's probably no good reason for us to expose both the "set" and "graph" versions of each phase as top-level commands. IMO it only adds confusion.

defaults={"graph_attr": "full_task_set"},
)
@command(
"full", help="Show the full taskgraph.", defaults={"graph_attr": "full_task_graph"}
"full",
help="Show the full taskgraph. The full taskgraph consists of the full task set, with edges (dependencies) between tasks.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/taskgraph/task graph

While we're making things less confusing, let's make it clear that we're not talking about the package here. Note this comment applies to all the commands.

@ahal
Copy link
Collaborator

ahal commented Dec 9, 2024

Filed #612 for my thought.

@gabrielBusta gabrielBusta force-pushed the gabriel-improved-cli-docs branch from deeb281 to 6e36df5 Compare January 2, 2025 16:36
@gabrielBusta gabrielBusta enabled auto-merge (squash) January 2, 2025 16:37
@gabrielBusta gabrielBusta merged commit 9b1b869 into main Jan 2, 2025
13 of 14 checks passed
@gabrielBusta gabrielBusta deleted the gabriel-improved-cli-docs branch January 2, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants